Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle cases when SDK config file is blank #171

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle cases when SDK config file is blank #171

wants to merge 2 commits into from
+31 −6

Conversation

pvthuyen
Copy link

gcloud CLI config file, ~/. config/gcloud/configurations/config_default could be blank if gcloud init is not run yet. In that case, Goth.Config.get_configuration_data/1 still returns an empty map instead of nil so the fallover to fetching from metadata server would not work.

@xfatedky
Copy link

thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xfatedky xfatedky xfatedky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvthuyen @xfatedky